From: Olivier Langlois <olivier@trillion01.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Stefan Roesch <shr@devkernel.io>,
io-uring@vger.kernel.org, kernel-team@fb.com,
ammarfaizi2@gnuweeb.org
Subject: Re: [PATCH v9 1/4] liburing: add api to set napi busy poll settings
Date: Fri, 02 Feb 2024 15:23:55 -0500 [thread overview]
Message-ID: <a6bd8fc18d15bf1be4ccf0a8cd4f5445cd849fa2.camel@trillion01.com> (raw)
In-Reply-To: <07EEF558-8000-436B-B9BD-0E0BAC40C2C3@kernel.dk>
On Fri, 2024-02-02 at 13:14 -0700, Jens Axboe wrote:
>
> Ah gotcha, yeah that’s odd and could not ever have worked. I wonder
> how that was tested…
>
> I’ll setup a liburing branch as well.
>
It is easy. You omit to check the function return value by telling to
yourself that it cannot fail...
I caught my mistake on a second pass code review...
C++ has a very useful [[nodiscard]] attribute that can help to catch
this simple error... I am not sure if there is something similar to the
[[nodiscard]] in the ISO C standard...
next prev parent reply other threads:[~2024-02-02 20:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 18:20 [PATCH v9 0/4] liburing: add api for napi busy poll Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 1/4] liburing: add api to set napi busy poll settings Stefan Roesch
2024-02-02 16:41 ` Olivier Langlois
2024-02-02 16:42 ` Jens Axboe
2024-02-02 17:41 ` Olivier Langlois
2024-02-02 17:48 ` Jens Axboe
2024-02-02 20:11 ` Olivier Langlois
2024-02-02 20:14 ` Jens Axboe
2024-02-02 20:23 ` Olivier Langlois [this message]
2024-02-02 22:20 ` Jens Axboe
2024-02-02 22:46 ` Jens Axboe
2024-02-03 2:30 ` Jens Axboe
2023-04-25 18:20 ` [PATCH v9 2/4] liburing: add documentation for new napi busy polling Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 3/4] liburing: add example programs for napi busy poll Stefan Roesch
2023-04-25 18:20 ` [PATCH v9 4/4] liburing: update changelog with new feature Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6bd8fc18d15bf1be4ccf0a8cd4f5445cd849fa2.camel@trillion01.com \
--to=olivier@trillion01.com \
--cc=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=shr@devkernel.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox